Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snmp]: Reduce Calls to SONiC Cfggen #5166

Merged

Conversation

tahmed-dev
Copy link
Contributor

Calls to sonic-cfggen is CPU expensive. This PR reduces calls to
sonic-cfggen to one call during snmp startup

singed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com

- Why I did it
Reduce time required to start snmp service

- How I did it
Used template batch mode to batch together two calls into one call sonic-cfggen

- How to verify it

root@str-s6000-acs-14:/# time ./start-old.sh

real	0m3.912s
user	0m3.223s
sys	0m0.613s
root@str-s6000-acs-14:/# time ./start-new.sh

real	0m1.988s
user	0m1.621s
sys	0m0.266s
root@str-s6000-acs-14:/# diff /etc/ssw/sysDescription.old /etc/ssw/sysDescription.new 
root@str-s6000-acs-14:/# diff /etc/snmp/snmpd.conf.old /etc/snmp/snmpd.conf.new

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

Calls to sonic-cfggen is CPU expensive. This PR reduces calls to
sonic-cfggen to once calle during snmp startup

singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
@tahmed-dev tahmed-dev marked this pull request as ready for review August 14, 2020 01:36
@tahmed-dev tahmed-dev merged commit cc97062 into sonic-net:master Aug 17, 2020
abdosi pushed a commit that referenced this pull request Oct 7, 2020
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to
sonic-cfggen to once calle during snmp startup

singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
lguohan pushed a commit that referenced this pull request Oct 30, 2020
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to
sonic-cfggen to once calle during snmp startup

singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
abdosi pushed a commit that referenced this pull request Dec 4, 2020
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to
sonic-cfggen to once calle during snmp startup

singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
abdosi pushed a commit that referenced this pull request Dec 22, 2020
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to
sonic-cfggen to once calle during snmp startup

singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to
sonic-cfggen to once calle during snmp startup

singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants